Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-frontend): comment out spaces UI to remove build issues #618

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

madhur-push
Copy link
Contributor

No description provided.

@madhur-push madhur-push self-assigned this Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

File: packages/examples/sdk-frontend/components/Spaces/useSpaceComponent.tsx

  1. The import statements are commented out. Uncomment them.
  2. The import statement for React is missing. Add it.
  3. The import statement for ENV is commented out. Uncomment it.
  4. The import statement for PushAPI is commented out. Uncomment it.
  5. There is a TypeScript error in the useContext line. The type for pgpPrivateKey is set as any. It should be string.
  6. You have commented out some lines that define the component props. Uncomment them.
  7. There are some commented out lines at the end of the file. Remove them.

File: packages/examples/sdk-frontend/package.json

  1. There is a typo in the devDependencies section. The closing curly brace is missing. Add it.

File: packages/examples/sdk-frontend/pages/_app.tsx

  1. The import statements for SpacesUIProvider and useSpaceComponents are commented out. Uncomment them.
  2. There is a TypeScript error in the SpaceComponentProvider component. The prop spaceUI is missing. Add it.
  3. There are some commented out lines in the MyApp component. Remove them.
  4. There is an unused import statement at the beginning of the file. Remove it.

File: packages/examples/sdk-frontend/pages/index.tsx

  1. There is an extra closing curly brace at the end of the Container styled component. Remove it.

File: packages/examples/sdk-frontend/pages/video.tsx

  1. This file is empty. Check if this is intentional or if there is missing code.

All looks good.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

File: packages/examples/sdk-frontend/components/Spaces/useSpaceComponent.tsx

The import statements are commented out. Uncomment them and remove the extra empty lines.

File: packages/examples/sdk-frontend/pages/_app.tsx

  1. Uncomment the import statement for SpacesUIProvider.

  2. Uncomment the import statement for useSpaceComponents and remove the './../' in the import path.

  3. Uncomment the SpacesComponentProvider component and wrap it around the Component element.

File: packages/examples/sdk-frontend/pages/index.tsx

Remove the extra closing brace '}' at the end of the file.

File: packages/restapi/README.md

Remove the extra empty lines.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

All looks good.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

All looks good.

@mohammeds1992 mohammeds1992 merged commit 769c20d into main Aug 9, 2023
1 check passed
@madhur-push madhur-push deleted the fix/push-video-example branch August 9, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants